Fix 726 improve dap compilation #840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the way the task or list of tasks were being checked. Creates a hook function for 'compilation-finish-functions' and adds the hook before calling 'compilation-start'. Changes 'dap-debug-compilation-keep' variable name to a more descriptive name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #726
There were some bugs in the way the TASKS were being check. It also set the hook for
compilation-startafter the functions was already called and banked on the fact that the command took long enough for us to set the hook, which seem like a strange thing to do.Also added two options:
dap-debug-compilation-keep-bufferto allow deleting the buffer on success.dap-debug-compilation-same-bufferto allow the commands to run on the same buffer without clearing the buffer.